Skip to content

Add Ruby 3.2 to the CI matrix#697

Merged
etagwerker merged 3 commits into
DatabaseCleaner:mainfrom
petergoldstein:feature/add_ruby_3_2_to_ci
Jan 26, 2023
Merged

Add Ruby 3.2 to the CI matrix#697
etagwerker merged 3 commits into
DatabaseCleaner:mainfrom
petergoldstein:feature/add_ruby_3_2_to_ci

Conversation

@petergoldstein

Copy link
Copy Markdown
Contributor

In addition to adding Ruby 3.2 to the CI matrix, I updated the version of the checkout action.

To get the specs to green I had to make a few additional changes:

  1. Add explicit hashes in the with clauses to remove ambiguity with keyword arguments
  2. Update the safeguard logic to treat an empty string for host as local.

This runs green on my fork.

@etagwerker etagwerker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petergoldstein Looks good, thank you! 👍🏼

@etagwerker
etagwerker merged commit 0ff5d01 into DatabaseCleaner:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants